Fix an issue with incorrect parsing of application command attachment parameters - #2472
Merged
akiraveliara merged 1 commit intoSep 15, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
akiraveliara
approved these changes
Sep 15, 2026
akiraveliara
deleted the
bugfix/2450-second-discordattachment-parameter-fails-to-parse-on-subcommands-argumentparseexception
branch
September 15, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you familiarize yourself with our contributing guidelines. (delete this line afterwards)
Summary
Fixes #2450
Details
Discord only gives us a single "attachments" option when we receive an interaction. The commands extension would check the index of the method parameter against the amount of parameters in total, which would always be 1. Any time more than 1 argument is of type DiscordAttachment, anything past the first argument would fail to parse because of this.
I'd argue the checks are way too strict anyway, since Discord guarantees a lot of stuff we check for.
but at the end of the day, it's still Discord.
Changes proposed
Notes
sup im back