FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

embeds are not nullable when editing a message by akiraveliara · Pull Request #2474 · DSharpPlus/DSharpPlus · GitHub

/ DSharpPlus Public

embeds are not nullable when editing a message #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akiraveliara merged 1 commit into from
Sep 19, 2026
+4 −3
Conversation 0 Commits 1 Checks 1 Files changed 3
Merged

embeds are not nullable when editing a message #2474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .cs  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions DSharpPlus/Entities/Interaction/Components/DiscordContainerComponent.cs
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public class DiscordContainerComponent : DiscordComponent
/// <summary>
/// The accent color for this container, similar to an embed.
/// </summary>
[JsonIgnore]
public DiscordColor? Color
{
get
Expand Down
4 changes: 2 additions & 2 deletions DSharpPlus/Net/Abstractions/Rest/RestChannelPayloads.cs
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ internal class RestChannelMessageEditPayload
[JsonIgnore]
public bool HasContent { get; set; }

[JsonProperty("embeds", NullValueHandling = NullValueHandling.Ignore)]
public IEnumerable<DiscordEmbed>? Embeds { get; set; }
[JsonProperty("embeds")]
public IEnumerable<DiscordEmbed> Embeds { get; set; }

[JsonProperty("allowed_mentions", NullValueHandling = NullValueHandling.Ignore)]
public DiscordMentions? Mentions { get; set; }
Expand Down
2 changes: 1 addition & 1 deletion DSharpPlus/Net/Rest/DiscordRestApiClient.cs
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2521,7 +2521,7 @@ public async ValueTask<DiscordMessage> EditMessageAsync
HasContent = content.HasValue,
Content = content.HasValue ? (string)content : null,
HasEmbed = embeds.HasValue && (embeds.Value?.Any() ?? false),
Embeds = embeds.HasValue && (embeds.Value?.Any() ?? false) ? embeds.Value : null,
Embeds = embeds.HasValue && (embeds.Value?.Any() ?? false) ? embeds.Value : [],
Components = components,
Flags = flags,
Attachments = attachments,
Expand Down
Loading
Back | FazBrowse Home | New Git URL