fix suppressing embeds from other users - #2476
Merged
akiraveliara merged 2 commits intoSep 23, 2026
Merged
akiraveliara merged 2 commits into
akiraveliara merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Naamloos
approved these changes
Sep 23, 2026
Naamloos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I don't see any cleaner way to solve this flags issue.
I do have questions about that weird ternary expression though
Sorry, something went wrong.
Comment thread
DSharpPlus/Net/Rest/DiscordRestApiClient.cs
akiraveliara
deleted the
aki/fix-suppressing-embeds-on-non-user-messages
branch
September 23, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously in #2467 and #2474, message flag and embed edit behaviour were changed to correctly edit messages from the current user, retaining message flags set on them and correctly handling the weird default value for embeds respectively.
this behaviour is, by some devilry, incorrect for editing user messages, where a different default value for embeds applies and where only the SuppressEmbeds flag (1 << 2) may be set, or else discord will interpret it as an attempt to edit another user's message and fail, even if it is simply retaining the provided flags
this pull request fixes that by hardwiring the behaviour for suppressing embeds from other users. it's probably not ideal but i don't really know how else to make this work