Thanks lad but just a few things:

• DiscordMessageApplication: shouldn't this just be an instance of Application? If not, perhaps Application should inherit from it, and it should be untied from messages (it has the more complete definition)
• DiscordMessageApplication: does not correctly initialize the Discord property.
• DiscordMessageReference: is there no better way to expose this? We want to avoid exposing solely IDs. Guilds and channels can be looked up on the client with 100% guarantee (unless you count guilds in different shards). DISREGARD THAT, I SUCK COCKS Messages may or may not be looked up from the cache.

Guilds and channels can be looked up on the client with 100% guarantee

Is that true here? Can message references not reference guilds the current user isn’t a part of?

Guilds and channels can be looked up on the client with 100% guarantee

Is that true here? Can message references not reference guilds the current user isn’t a part of?

You raise a great point, I did not take that into consideration.

Thanks lad but just a few things:

* DiscordMessageApplication: shouldn't this just be an instance of Application? If not, perhaps Application should inherit from it, and it should be untied from messages (it has the more complete definition)

I don't feel it should inherit from DiscordApplication because there would be many properties that wouldn't get used if it is sent as a message property.

* DiscordMessageApplication: does not correctly initialize the Discord property.

How so?

* DiscordMessageReference: is there no better way to expose this? We want to avoid exposing solely IDs. Guilds and channels can be looked up on the client with 100% guarantee (unless you count guilds in different shards). Messages may or may not be looked up from the cache.

I thought about this, but I chose to keep these just as IDs because the client would need to be in the same server as the original message (for a news channel) in order for it not to be null. Maybe when more guilds have access to news channels it would make sense but I just don't see the point of adding it when news channels are still experimental.

I don't feel it should inherit from DiscordApplication because there would be many properties that wouldn't get used if it is sent as a message property.

I meant to inherit them the other way around.

How so?

All SnowflakeObject types must initialize the client property, via the constructor. At least for now, the deserializer cannot do this.

I thought about this, but I chose to keep these just as IDs because the client would need to be in the same server as the original message (for a news channel) in order for it not to be null. Maybe when more guilds have access to news channels it would make sense but I just don't see the point of adding it when news channels are still experimental.

Not null - skeleton objects should be used instead. That's how it works elsewhere in the lib.

I don't feel it should inherit from DiscordApplication because there would be many properties that wouldn't get used if it is sent as a message property.

I meant to inherit them the other way around.

How so?

All SnowflakeObject types must initialize the client property, via the constructor. At least for now, the deserializer cannot do this.

I thought about this, but I chose to keep these just as IDs because the client would need to be in the same server as the original message (for a news channel) in order for it not to be null. Maybe when more guilds have access to news channels it would make sense but I just don't see the point of adding it when news channels are still experimental.

Not null - skeleton objects should be used instead. That's how it works elsewhere in the lib.

Ah I see, I'll edit those then.

So for creating the skeleton objects, should I just always return a skeleton object for the message references? Or should I try to search through the message, guild, and channel caches and return the full object if it's there, and if not then return a skeleton object?

DiscordMessageApplication is the correct way of handling this, though I only glanced at the solution.

Guilds are, like everything in Discord, not 100% guaranteed, particularly in sharded scenarios.

As far as message reference goes, I think you should just make it an object with supplied data and optionally a method to fetch the message. No real point in doing much beyond that.

I just wrote this in the constructor to fetch those objects from the cache or just create new objects. Don't really know how to test this without a news channel though:

internal DiscordMessageReference()
        {
            if (this.guildId.HasValue && this.client._guilds.TryGetValue(this.guildId.Value, out var g))
                this.Guild = g;

            else this.Guild = new DiscordGuild
            {
                Id = this.guildId.Value
            };

            var channel = this.client.InternalGetCachedChannel(this.channelId);

            if (channel == null)
                this.Channel = new DiscordChannel
                {
                    Id = this.channelId,
                    GuildId = this.guildId.Value
                };

            else this.Channel = channel;

            if (messageId.HasValue && this.client.MessageCache.TryGet(m => m.Id == messageId.Value && m.ChannelId == channelId, out var msg))
                this.Message = msg;

            else this.Message = new DiscordMessage
            {
                Id = this.messageId.Value,
                ChannelId = this.channelId
            };
        }

Since it's not tested I think just creating skeleton objects would be the safest option. What do you all think?

Since it's not tested I think just creating skeleton objects would be the safest option. What do you all think?

This looks fine, but be sure to set the .Discord property of these skeleton objects, and add them to their appropriate parent objects. Dwarfed entities aren't a fun time

Yeah good point