FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for <Node.getLastCommonParent Algorithm #5> by jbraybrook · Pull Request #15 · DaisyDiff/DaisyDiff · GitHub

Fix for <Node.getLastCommonParent Algorithm #5> - #15

Open
jbraybrook wants to merge 1 commit into
DaisyDiff:masterfrom
jbraybrook:fix/get-last-common-parent
Open

Fix for <Node.getLastCommonParent Algorithm #5>#15
jbraybrook wants to merge 1 commit into
DaisyDiff:masterfrom
jbraybrook:fix/get-last-common-parent

Conversation

Copy link
Copy Markdown

Fix for issue <Node.getLastCommonParent Algorithm #5> following suggestion in the comments on that issue. Although the issue has been closed it is still a problem in the product.

This change allows the getLastCommonParent algorithm to call the TagNode.isSameTag() method with an extra parameter to force it to ignore attribute differences when comparing tags.

Copy link
Copy Markdown
Contributor

Hello,

Unfortunately, we, at the Nuxeo organization, are no more maintaining this repository, unless for critical security fixes.
Maybe @peter-kehl, the other repository owner, could help?

Otherwise, don't hesitate to check the project's forks to find a potential maintainer or to fork it yourself.

Besides, @peter-kehl, we're thinking about archiving this repository to make it read-only and disable any future comments.
The repository could then still be forked, or unarchived if needed.
What do you think?

Regards,

jbraybrook commented Aug 6, 2020 via email
edited
Loading

Copy link
Copy Markdown
Author

Copy link
Copy Markdown
Member

Hi @ataillefer,
What's the benefit of archiving/freezing this? Is it so that Nuxeo software doesn't break due to DaisyDiff changes? If so, couldn't you create a tag and point at it instead?

Hi @jbraybrook and @ataillefer,
Unfortunately, due to permanent overload I can't maintain this. Any ideas other than telling people to fork (and increase confusion/entropy)?

Copy link
Copy Markdown
Contributor

Hi @peter-kehl,
We were thinking about archiving the repository to prevent people from opening issues and pull requests that would never be handled, since neither you nor us are willing to maintain it.

We are already relying on the latest release-1.2-NX4 tag so that's not really an issue.

Indeed, multiplying the forks might not the best idea.
We could, if some people are willing to maintain this repository, grant them Owner/Administrator access.
Then, at Nuxeo, we would probably do our own fork and rely on it to be sure we're working on a "frozen" master branch from which we could perform additional releases if needed...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL