FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed flaky test by kr-igor · Pull Request #9218 · DataDog/dd-trace-java · GitHub

/ dd-trace-java Public

Fixed flaky test #9218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kr-igor merged 2 commits into from
Jul 22, 2025
Conversation 5 Commits 2 Checks 174 Files changed
Merged

Fixed flaky test #9218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
557cbfc
Fixed flaky test
kr-igor Jul 22, 2025
69efa01
Removed kafka cluster id check, as it's sometimes equal to empty string
kr-igor Jul 22, 2025
File filter

Filter by extension

Filter by extension .groovy  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion ...nt/instrumentation/kafka-clients-0.11/src/latestDepTest/groovy/KafkaClientTestBase.groovy
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ abstract class KafkaClientTestBase extends VersionedNamingTestBase {
"type:kafka"
)
}
def sorted = new ArrayList<DataStreamsTags>(TEST_DATA_STREAMS_WRITER.backlogs).sort()
def sorted = new ArrayList<DataStreamsTags>(TEST_DATA_STREAMS_WRITER.backlogs).sort({it.type+it.partition})
verifyAll(sorted) {
size() == 2
get(0).hasAllTags("consumer_group:sender",
Expand Down
4 changes: 2 additions & 2 deletions ...nstrumentation/kafka-connect-0.11/src/test/groovy/ConnectWorkerInstrumentationTest.groovy
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,12 @@ class ConnectWorkerInstrumentationTest extends AgentTestRunner {

StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
verifyAll(first) {
tags.hasAllTags("direction:out", "topic:test-topic", "type:kafka", "kafka_cluster_id:" + clusterId)
tags.hasAllTags("direction:out", "topic:test-topic", "type:kafka")
}

StatsGroup second = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == first.hash }
verifyAll(second) {
tags.hasAllTags("direction:in", "group:connect-file-sink-connector", "topic:test-topic", "type:kafka", "kafka_cluster_id:" + clusterId)
tags.hasAllTags("direction:in", "group:connect-file-sink-connector", "topic:test-topic", "type:kafka")
}
TEST_DATA_STREAMS_WRITER.getServices().contains('file-sink-connector')

Expand Down
Back | FazBrowse Home | New Git URL