Track gtest test-directory headers as compile inputs - #834
Draft
jbachorik wants to merge 1 commit into
Draft
jbachorik wants to merge 1 commit into
jbachorik wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 61a1df4 | Docs | View more details | Give us feedback! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
CI Test ResultsRun: #36852315882 | Commit: 0b87f77 | Duration: 15m 40s (longest job)
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-10-01 11:15:58 UTC |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Registers the .inc and .h files in each gtest's test directory as inputs of its native compile task (GtestTaskBuilder.kt).
Motivation:
NativeCompileTask declares only sources and the includes directories as inputs. Test .cpp files include .inc/.h files from the test directory by a relative path, and that directory is not an include dir. An edit to such a file leaves compileGtest* UP-TO-DATE, so the old test binary runs and shows results that do not reflect the change. touch does not help (Gradle hashes contents); only --rerun-tasks forces a rebuild.
Additional Notes:
Main has no .inc/.h files in ddprof-lib/src/test/cpp yet, so the bug is latent here; #797 adds them.
How to test the change?:
Edit a test-directory .h or .inc file and run ./gradlew :ddprof-lib:compileGtestDebug_<test>. Without this change the task is UP-TO-DATE; with it, the task reruns.
For Datadog employees:
credentials of any kind, I've requested a security review (run the dd:platform-security-review
skill, or file a request via the PSEC review form).
bewaire also runs automatically on every PR.
🤖 Generated with Claude Code