Reset the iterator in LatLongPrecisionParser when one of them error out - #178
Closed
Ladsgroup wants to merge 1 commit into
Closed
Reset the iterator in LatLongPrecisionParser when one of them error out#178Ladsgroup wants to merge 1 commit into
Ladsgroup wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This avoids errors like "Cannot rewind a generator that was already run" When the first parser has invalid value but everything after it is okay Caught with an integration test in ParserValue API module in Wikibase Bug: T238931
reedy
approved these changes
Dec 18, 2019
Copy link
Copy Markdown
Member
|
That is pretty strange. The generator is wrapped by CachingIterator, so rewind errors should not happen. I'll have a look later today and write some unit tests to get to the bottom of this. |
Sorry, something went wrong.
JeroenDeDauw
added a commit
that referenced
this pull request
Dec 18, 2019
Copy link
Copy Markdown
Member
|
Apparently CachingIterator does not fully cache for partial iterations, hence the error. That makes the code using CachingIterator here pointless, so I've removed it in #180, which fixes the error. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids errors like "Cannot rewind a generator that was already run"
When the first parser has invalid value but everything after it is okay
Caught with an integration test in ParserValue API module in Wikibase
Bug: https://phabricator.wikimedia.org/T238931