Bug fix spatiotemporal adaptation kwargs - #2291
Merged
MMathisLab merged 2 commits intoJun 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MMathisLab
approved these changes
Jun 29, 2023
yeshaokai
approved these changes
Jun 29, 2023
yeshaokai
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good to me
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug documented in issue #2282. In adaptation_training, an adapt_iterations key was read from the kwargs without providing a default value. This behavior changes to use the default adapt_iterations attribute for the class.
Additionally, train_without_project now uses the adapt_iterations of the class as a default, instead of overwriting it with 1000.
Black was also run on the file, leading to style changes.