Manual outlier_frame_extraction bugfix - #2307
Merged
MMathisLab merged 5 commits intoJul 15, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jeylau
reviewed
Jul 12, 2023
Comment thread
deeplabcut/refine_training_dataset/outlier_frames.py
Outdated
Copy link
Copy Markdown
Contributor
|
Should we pin tensorflow to <2.13 to avoid failing tests? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Should we do this in a separate pull request or directly here? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
I'd do it separately, and merge it in main before this one. |
Sorry, something went wrong.
jeylau
approved these changes
Jul 14, 2023
MMathisLab
approved these changes
Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #2279.
When manually extracting outlier frames from a video (not located in the {project}/videos/ folder), two issues were occurring:
There napari-deeplabcut tried to extract the frames to a labeled-images folder located in the parent folder of the analyzed video (which logically did not exist). This pull request fixes these issues.