Avoid assembling if already done and overwrite == False - #2317
Conversation
Sorry, something went wrong.
This QoL significantly reduces time needed for testing different inference parameters by reading assemblies from an existing file (if already run once). Works for both identity True and False.
| with open(pickle_path, "rb") as file: | ||
| data = pickle.load(file) | ||
|
|
||
| self.assemblies = {key: value for key, value in data.items() if key != "single"} |
There was a problem hiding this comment.
self.unique = data.pop('single', {})
self.assemblies = data
Sorry, something went wrong.
There was a problem hiding this comment.
Done. A small annoyance is that it hangs a little when loading the assemblies.pickle, but I don't think this can be avoided
Sorry, something went wrong.
There was a problem hiding this comment.
No worries! That's nothing in comparison to the time that would otherwise be spent forming the assemblies.
Sorry, something went wrong.
jeylau
left a comment
There was a problem hiding this comment.
Just left a minor comment about ass_filename; all good otherwise!
Sorry, something went wrong.
|
Renamed to assembly_builder, seems appropriate and avoids confusion with the class name. Also added assemblies_filename as a variable before the if statement |
Sorry, something went wrong.
|
Looking good, thanks @KonradDanielewski! |
Sorry, something went wrong.
This QoL significantly reduces time needed for testing different inference parameters by reading assemblies from an existing file (if already run once). Works for both identity True and False.