| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Good catch! And concise, elegant fix! 😊
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes the installation of FFmpeg in the MacOS runner. The installation on was failing because the Homebrew installation did not complete successfully because of the following error:
Basically, one of the dependencies for FFmpeg is libass, which requires python@3.12. But due to the existing installation of python on the runner, it fails to create one of the symlinks. I believe this error can be ignored, as described here. It also says that we could then run brew link --overwrite python@3.12, but this does not seem to be necessary to run the tests. I also would not want the default python version to be updated to 3.12 (instead of 3.9 or 3.10), so I think we can ignore that step.
So just updating the CI to ignore Homebrew's return code is enough to fix the issue. One issue with this fix is that in the future, if something else with homebrew fails, it might break something further down in the CI/CD pipeline. I still think this is the best way to go.