FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix minimalnumberofconnections by segashin · Pull Request #2718 · DeepLabCut/DeepLabCut · GitHub

Fix minimalnumberofconnections - #2718

Merged
MMathisLab merged 4 commits into
DeepLabCut:mainfrom
segashin:fix-minimalnumberofconnections
Sep 6, 2024
Merged

Fix minimalnumberofconnections#2718
MMathisLab merged 4 commits into
DeepLabCut:mainfrom
segashin:fix-minimalnumberofconnections

Conversation

Copy link
Copy Markdown
Contributor

I've noticed that convert_detections_to_tracklets always uses the default value for min_n_links. Based on the comment on inference_cfg.yaml sample, the value at minimalnumberofconnctions should be used instead.

#least number of connections (to actually form an animal)
minimalnumberofconnections: willbeautomaticallyupdatedbycreate_training_datasetcode

This pull request makes the following change.

  • Read minimalnumberofconnections from inference_cfg.yaml and use it as min_n_links when creating the Assembler.

MMathisLab requested a review from AlexEMG August 26, 2024 09:48
MMathisLab requested a review from n-poulsen September 5, 2024 15:48

n-poulsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Thanks for the fix, @segashin!

MMathisLab merged commit a9c613f into DeepLabCut:main Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL