Timeout retrieving latest package version from the Web - #2782
Merged
n-poulsen merged 2 commits intoNov 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
maximpavliv
force-pushed
the
maxim/timeout_check_for_updates
branch
from
1615eca to
bebcb0d
Compare
November 13, 2024 18:21
maximpavliv
force-pushed
the
maxim/timeout_check_for_updates
branch
from
d15256e to
4dfe156
Compare
November 14, 2024 09:31
n-poulsen
approved these changes
Nov 14, 2024
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Great fix thanks Maxim (really nice to not have the update message when on an RC version)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This morning, I had deeplabcut GUI stuck in utils.is_latest_deeplabcut_version() and in misc.is_latest_version(). After some investigation, it seems like
was stuck because of some firewall or DNS in Python, but it was working when I was getting the data from the CLI (using curl) or in a web browser.
This case is not handeled by the except URLError block of _check_for_updates(), this PR adds a timeout to trying to read the latest available package versions.