Fix reading filtered state - #2844
Merged
maximpavliv merged 2 commits intoJan 24, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
n-poulsen
approved these changes
Jan 24, 2025
n-poulsen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@maximpavliv Looks good to me, thanks! Did you check if there's anywhere else in the code that we're using checkState()?
Sorry, something went wrong.
maximpavliv
force-pushed
the
maxim/fix_reading_filtered_checkbox_state
branch
from
85ba09c to
a52489a
Compare
January 24, 2025 11:01
Copy link
Copy Markdown
Contributor
Author
|
@n-poulsen You're right, this error was present in a few other places. Fixed them as well and refactored a bit, can you review again please? |
Sorry, something went wrong.
n-poulsen
approved these changes
Jan 24, 2025
n-poulsen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me, thanks!
Sorry, something went wrong.
maximpavliv
force-pushed
the
maxim/fix_reading_filtered_checkbox_state
branch
from
a52489a to
ff6f050
Compare
January 24, 2025 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Create Video tab in the GUI, unfiltered videos could not be created because of an incorrect reading of the "Use filtered data" checkbox state.
This PR fixes this bug