fix evaluation for ma models, following change in 'deeplabcut/core/metrics/api.py' - #2872
Merged
n-poulsen merged 1 commit intoFeb 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is a supplemental fix for Commit 40465e1 invert
n-poulsen
approved these changes
Feb 14, 2025
n-poulsen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Hi @Zelin2001 - thanks for your fix! Looks good to me!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a supplemental fix for Commit 40465e1 "fix - evaluation during training for ma models".
Following the principles of the previous fix, this minor change passed "compute_detection_rmse" argument to "compute_metrics()". To me, this fixed the assertion error in my multi-animal project which was comparable to what caused the 40465e1 fix.