Save all pytorch config updates in dlc_torch.train_network() - #3062
Merged
AlexEMG merged 2 commits intoJul 24, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you! Please update so it only saves if a change was made. |
Sorry, something went wrong.
AlexEMG
self-requested a review
July 22, 2025 11:32
Copy link
Copy Markdown
Contributor
Author
Done! |
Sorry, something went wrong.
AlexEMG
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request saves all updates done to the model configuration to the disk (pytorch_config.yaml) before starting training in dlc_torch.train_network().
Previously, the pytorch config was only saved when pytorch_cfg_updates were passed. This prevented saving other updated fields.