| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This PR fixes the likelihood computation in SimCCPredictor to make it consistent with the MMPose decoding logic. The main issue was that likelihoods were either exceeding 1 (returning raw logits) or were extremely small due to improper softmax application across the entire SimCC space.
Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| deeplabcut/pose_estimation_pytorch/models/predictors/sim_cc.py | Core fix - adds sigma/decode_beta scaling and changes default apply_softmax to True |
| Multiple RTMPose config files | Adds sigma and decode_beta parameters to model configurations |
| Multiple other files | Cleanup of superanimal_humanbody specific code and infrastructure improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
|
cc @maximpavliv can you adress copilots suggestions? |
Sorry, something went wrong.
@MMathisLab yes, done! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Background
The likelihoods (confidences) produced by SimCCPredictor were not consistent with the expected behavior of SimCC decoding.
This mismatch originated from how the raw SimCC representation vectors (logits over discretized x/y coordinates) were converted into coordinates and visibility scores.
See the original MMPose predictor implementation for reference.
Changes
This PR brings SimCCPredictor closer to the original MMPose decoding logic:
1. Added parameters
Together, sigma * decode_beta ensures that visibility/confidence is decoded consistently with the label distribution used in training.
2. Likelihood computation
3. Default behavior
Outcome