Expose close_figure_after_save in superanimal_analyze_images() - #3082
Merged
AlexEMG merged 35 commits intoSep 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
You were right @AlexEMG , the close_figure_after_save parameter in superanimal_analyze_images() was originally set to False for its usage in the COLAB_YOURDATA_SuperAnimal.ipynb notebook! Therefore I changed the default to True, and added close_figure_after_save=False in the notebook. |
Sorry, something went wrong.
AlexEMG
approved these changes
Sep 10, 2025
Copy link
Copy Markdown
Member
|
Excellent! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR exposes the close_figure_after_save parameter in superanimal_analyze_images() and sets its default value to True. This ensures that figures are closed after being saved, preventing matplotlib from issuing warnings when many figures are created in sequence.
To preserve interactive visualization in tutorials, the COLAB_YOURDATA_SuperAnimal.ipynb notebook has been updated to explicitly set close_figure_after_save=False.
Motivation:
A user reported on the forum that they encounter:
By default, figures are now closed automatically after saving, suppressing this warning. Users who want to keep figures open (e.g., in notebooks) can set close_figure_after_save=False.