Remove config editor delegate hack. - #3167
Merged
MMathisLab merged 1 commit intoJan 9, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This commit fixes issue DeepLabCut#3165, with the GUI DictViewer configuration editor widget. A hack was implemented that prevented editing the config fields, using a custom QItemDelegate that caused segmentation fault when converting invalid return values in C++. This commit removes the custom delegate. The user can now edit all fieldnames
2 tasks
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a workaround that prevented users from editing configuration field names in the GUI's DictViewer widget. The custom delegate was causing segmentation faults and unnecessarily restricted editing capabilities. The change enables full editing of configuration fields while resolving the crash issue.
Key changes:
- Removed the CustomDelegate class that was blocking edits to the first column
- Removed the delegate assignment from the DictViewer initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
MMathisLab
self-requested a review
January 9, 2026 14:50
MMathisLab
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #3165, with the GUI DictViewer configuration editor widget.
A hack was implemented that prevented editing the config fields, using a custom QItemDelegate that caused segmentation fault when converting invalid return values in C++. This commit removes the custom delegate. The user can now edit all fieldnames.