fix rename_mapping in download_huggingface_model (change arg type str -> dict) - #3196
Merged
C-Achard merged 1 commit intoFeb 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@MMathisLab, it would be great to merge this to fix a small bug in download_huggingface_model when it is used with older versions of dlclibrary. |
Sorry, something went wrong.
C-Achard
approved these changes
Feb 13, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #3192
Issue
When downloading a model from huggingface for superanimal weight initialization, download_huggingface_model is called with argument rename_mapping=model_filename. Newer dlclibrary (version =>0.0.9, see DeepLabCut/DLClibrary@0ce7473) can convert this string argument to a dict, but older versions expect a dict argument. Running the current code in DeepLabCut with an older dlclibrary installation will raise AttributeError: 'str' object has no attribute 'get'.
Changes
This PR replaces the str-type argument rename_mapping=model_filename with a dictionary: rename_mapping={model_filename:model_filename}, so that it works both with older and newer dlclibrary versions.