Replace str, os.path with pathlib.Path - #3199
Merged
deruyter92 merged 3 commits intoFeb 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This commit contains squashed changes by juan-cobos - Began to refactor pathlib for os - Fixed filename replacement with Path - Remove output_path, stick to dest_folder for compatibility - refactored find_analyzed_data from auxiliaryfunctions - removed accidental import - match previous msg improving readibility - Fixed underscore name - remove comments and make scorer str for safety - fixed paths when weights are provided - address copilot and deruyter changes - remove scorer str conversion - find_analyzed_data using .glob - fixed Path + str when using tmpfolder - return True if videooutname already created, same as above logic
C-Achard
self-requested a review
February 13, 2026 13:27
C-Achard
approved these changes
Feb 13, 2026
C-Achard
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good ! Thanks
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement PR for #3170
Motivation (as phrased by @juan-cobos in the original PR):
Path handling is currently inconsistent (strings vs Path objects, mixed os.path and pathlib), making code hard to follow. This also causes subtle bugs (e.g., scorer.replace() on a Path attempts filesystem operations instead of string replacement). Standardizing on pathlib.Path would help to make older code consistent with newer parts of the codebase.
Changes:
Standardize on pathlib.Path internally with proper type hints in the following files: