Fix save_original bug in the processors - #75
Merged
C-Achard merged 3 commits intoMay 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… error management and remove redundant timeout setting
Copy link
Copy Markdown
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sorry, something went wrong.
C-Achard
approved these changes
May 5, 2026
C-Achard
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I did generally document the processor more as an example of what could be done, rather than a fully supported feature, so I think in this case I would keep the changes minimal.
Thanks for the fix !
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example processors as well as the base processor had a bug in the recording logic of the original dlc-keypoints. Results should only be appended when the processor is set in the 'record' mode and not on every process-call.
Additionally removed the conn._socket accesses as at least on windows this does not exist. and leads to AttributeError.
@C-Achard those are quick-fixes from my side, you are welcome to use a better approach.