FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

+ New option - codepage of source files. Could be set via command line argument `-cp` or read from DPROJ by Fr0sT-Brutal · Pull Request #9 · DelphiCodeCoverage/DelphiCodeCoverage · GitHub

/ DelphiCodeCoverage Public

+ New option - codepage of source files. Could be set via command line argument -cp or read from DPROJ - #9

Closed
Fr0sT-Brutal wants to merge 5 commits into
DelphiCodeCoverage:masterfrom
Fr0sT-Brutal:feat_codepage
ConversationCommits (5)ChecksFiles changed
Closed

+ New option - codepage of source files. Could be set via command line argument -cp or read from DPROJ#9
Fr0sT-Brutal wants to merge 5 commits into
DelphiCodeCoverage:masterfrom
Fr0sT-Brutal:feat_codepage

Conversation

Fr0sT-Brutal commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

WARNING this PR depends on changes made by feat_read-searchpath-from-dproj PR.

Laurensvanrun commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Thanks for your contribution. Can you also add tests for reading this information from the DPROJ?

Fr0sT-Brutal commented Aug 10, 2021

Copy link
Copy Markdown
Contributor Author

Done! I can rebase the commit once you merge feat_read-searchpath-from-dproj for simpler history

Laurensvanrun commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

That would be nice, feat_read-searchpath-from-dproj is merged.

Fr0sT-Brutal deleted the feat_codepage branch August 10, 2021 14:35
Fr0sT-Brutal mentioned this pull request Aug 10, 2021
Merged

Fr0sT-Brutal commented Aug 10, 2021

Copy link
Copy Markdown
Contributor Author

Closed this accidentally by removing branh, so rereated as #11

Laurensvanrun commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

I'm I correct that it reads the codepage from the DPROJ by default and that your commandline parameter overrules it? If so, can you please add this as comment in the readme?

Fr0sT-Brutal commented Aug 13, 2021

Copy link
Copy Markdown
Contributor Author

Well, I've short of time currently and can't check but it seems to me that this depends on the order of arguments because DPROJ is read right when the option is encountered. So if -cp appears after, it will overwrite the value read from DPROJ

Fr0sT-Brutal commented Aug 19, 2021

Copy link
Copy Markdown
Contributor Author

@Laurensvanrun added the note

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL