Issue #967 drn conversion - #1046
Merged
luitjansl merged 32 commits intoMay 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…version # Conflicts: # imod/mf6/rch.py # imod/tests/fixtures/backward_compatibility_fixture.py # imod/tests/test_mf6/test_mf6_rch.py # imod/tests/test_typing/test_typing_grid.py # imod/typing/grid.py
JoerivanEngelen
requested changes
May 22, 2024
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I have some comments, I think you can make more use of some of the functionality introduced in the RCH PR and make it more consistent with that. In the sense that:
- Only a single package is returned.
- This package is selected with a key argument
- Allocation and distribution of conductances only happens when layer = 0 (is_planar_grid returns True)
Sorry, something went wrong.
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
JoerivanEngelen
approved these changes
May 24, 2024
JoerivanEngelen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Got a few comments, approving in advance
Sorry, something went wrong.
Comment thread
imod/mf6/drn.py
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/mf6/drn.py
Outdated
Comment thread
imod/tests/test_mf6/test_mf6_drn.py
Outdated
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
…es/imod-python into issue_#967_drn_conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #967
Description
implements importing drainage packages from imod5 data. Adds tests.
Methods for allocation and conductivity assignment can be specified per package, but it requires knowledge on what the packages are called in the imod5 project file (like "drn-1" and "drn-2"). If not specified, defaults are in place.
Checklist