Issue #968 import river - #1061
Merged
luitjansl merged 25 commits intoJun 7, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…river # Conflicts: # imod/mf6/riv.py
JoerivanEngelen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, my main comment is that I don't think the large amount of deepcopying dicts is a good idea, I have some pragmatic suggestion which avoids a lot of copying overhead. Probably also good to investigate why/when copying is required in the first place.
Sorry, something went wrong.
Comment thread
imod/mf6/model_gwf.py
Comment thread
imod/mf6/model_gwf.py
Outdated
Comment thread
imod/mf6/riv.py
Comment thread
imod/mf6/riv.py
Outdated
Comment thread
imod/mf6/riv.py
Comment thread
imod/mf6/riv.py
Outdated
Comment thread
imod/mf6/riv.py
Outdated
Comment thread
imod/tests/test_mf6/test_mf6_riv.py
Comment thread
imod/mf6/riv.py
Outdated
Comment thread
imod/tests/test_mf6/test_mf6_simulation.py
Outdated
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
review comments Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
review comment Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
JoerivanEngelen
approved these changes
Jun 7, 2024
JoerivanEngelen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, thanks for implementing!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #968
Description
Imports riverpackages from IMOD5. The infiltration factor (which does not exist in MF6) is accounted for by creating a drainage package.
Checklist