Issue #1052 log filtered wells - #1067
Merged
JoerivanEngelen merged 7 commits intoJun 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ltered_wells # Conflicts: # imod/mf6/wel.py
JoerivanEngelen
approved these changes
Jun 11, 2024
JoerivanEngelen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, I see you missed updating the message to the changelog. I will do that. Approving in advance.
Sorry, something went wrong.
Comment thread
docs/api/changelog.rst
Outdated
| ~~~~~~~ | ||
| - :class:`imod.mf6.Well` now also validates that well filter top is above well filter bottom | ||
| - :function:`open_projectfile_data` now also imports well filter top and bottom. | ||
| - :class:`imod.mf6.Well` now also validates that well filter top is above well filter bottom |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I see you planned to update the changelog, copy pasted a previous line, but forgot to update the message?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1052
Description
when importing wells from imod5: If not all wells could be assigned to the modflow6 model (this can be due to inactive cells,
or due to constraints of minimum thickness/permeability) then a log message will be generated to document in the log
file that not all wells were successfully imported.
Checklist