Issue #502 hfb import - #1070
Merged
JoerivanEngelen merged 7 commits intoJun 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
JoerivanEngelen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, I have one suggestion to avoid using deprecated pandas functionality
Sorry, something went wrong.
Comment thread
imod/mf6/hfb.py
Comment on lines
+1104
to
+1107
| if compound_dataframe is None: | ||
| compound_dataframe = geometry_layer | ||
| else: | ||
| compound_dataframe = compound_dataframe._append(geometry_layer) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Appending to pandas dataframes is deprecated. Collecting the dataframes in a list and concatenating is preferred:
Suggested change
| if compound_dataframe is None: | |
| compound_dataframe = geometry_layer | |
| else: | |
| compound_dataframe = compound_dataframe._append(geometry_layer) | |
| compound_ls.append(geometry_layer) | |
| compound_dataframe = pd.concat(compound_ls, axis="index") |
Sorry, something went wrong.
JoerivanEngelen
added a commit
that referenced
this pull request
Jun 18, 2024
Follow-up on: #1070 # Description For some reason, I erronously merged #1070. This implements my suggestion to concatenate pandas dataframes. # Checklist <!--- Before requesting review, please go through this checklist: --> - [x] Links to correct issue - [ ] Update changelog, if changes affect users - [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [ ] Unit tests were added - [ ] **If feature added**: Added/extended example --------- Co-authored-by: luitjan <luitjan.slooten@deltares.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502
Description
Converts hfb's from imod5 to mf6, but only in the following cases:
It creates a single mf6 hfb package containing all the hfb's that are present in the model domain area.
The hfb package is added to the simulation.
Checklist