FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

issue #1083 duplicate wells by luitjansl · Pull Request #1086 · Deltares/imod-python · GitHub

issue #1083 duplicate wells - #1086

Merged
luitjansl merged 3 commits into
imod5_converter_feature_branchfrom
issue_#1083_duplicate_wells
Jun 26, 2024
Merged

issue #1083 duplicate wells #1086
luitjansl merged 3 commits into
imod5_converter_feature_branchfrom
issue_#1083_duplicate_wells

Conversation

Copy link
Copy Markdown
Contributor

Fixes #1083

Description

When importing wells, we now make sure that when the ipf file defines 2 or more wells with the same x, y , filter_top, filter_bottom and id, then the ID of the second well is appended with "_1", and so on for successive findings of a well with the same characteristics (_2, _3 etc).

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

luitjansl changed the title added test issue_#1083_duplicate_wells Jun 24, 2024
luitjansl changed the title issue_#1083_duplicate_wells issue #1083 duplicate wells Jun 24, 2024

JoerivanEngelen left a comment
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! I see the linter failed btw, so please format that. Approving in advance!

luitjansl merged commit 9f274bd into imod5_converter_feature_branch Jun 26, 2024
luitjansl deleted the issue_#1083_duplicate_wells branch June 26, 2024 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL