Issue #1187 cleanup wells - #1206
Merged
JoerivanEngelen merged 28 commits intoSep 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- make to test for columnnames kwarg configurable with kwarg
Copy link
Copy Markdown
Contributor
Author
|
FYI: I fixed the issues Sonarcloud raised, but it keeps reviewing an old changeset... |
Sorry, something went wrong.
Manangka
reviewed
Sep 11, 2024
Comment thread
imod/mf6/wel.py
Comment thread
imod/mf6/wel.py
Outdated
Comment thread
imod/prepare/cleanup.py
Outdated
Copy link
Copy Markdown
|
Sorry, something went wrong.
Manangka
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1187
Description
Adds cleanup utility for wells, as well as a method on the Well object. LayeredWell doesn't have cleanup method yet, as cleaning up almost purely focuses on adjusting filter screen levels for now. The function as well as the method are a bit more involved than the other cleanup utilities, because we are dealing here with a comparison of point data and grids.
Checklist