FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Issue #1209 bypass value error well assign by JoerivanEngelen · Pull Request #1211 · Deltares/imod-python · GitHub

/ imod-python Public

Issue #1209 bypass value error well assign - #1211

Merged
JoerivanEngelen merged 13 commits into
imod5_converter_feature_branchfrom
issue_#1209_bypass_ValueError_well_assign
Sep 17, 2024
ConversationCommits (13)ChecksFiles changed
Merged

Issue #1209 bypass value error well assign#1211
JoerivanEngelen merged 13 commits into
imod5_converter_feature_branchfrom
issue_#1209_bypass_ValueError_well_assign

Conversation

JoerivanEngelen commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

Fixes #1209

Description

  • Add setting to to_mf6_pkg: error_on_well_removal, which throws an error if wells are removed entirely during well assignment.
  • Separated code to collect filtered well ids in separate method. This method is now also called to collect ids of errors being removed in error message.
  • Added attribute _is_from_imod5 to Modflow6Simulation to keep track if the simulation is loaded from iMOD5 data or not. Based on this, some validation settings might be set to be a bit more permissive. (Or call some extra cleanup?)
  • is_from_imod5 property to WriteContext to keep track of the same thing within the writing context.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

JoerivanEngelen changed the base branch from master to imod5_converter_feature_branch September 12, 2024 13:00
Manangka requested changes Sep 13, 2024
View reviewed changes
Comment thread imod/mf6/simulation.py
self.name = name
self.directory = None
self._initialize_template()
self._is_from_imod5 = False

Manangka Sep 13, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm imod5 converter logic is now being mixed up with the main logic. I'm not sure this is a good thing

JoerivanEngelen Sep 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point, will be picked up further in #1222

Comment thread imod/mf6/wel.py Outdated
Comment thread imod/mf6/wel.py Outdated
JoerivanEngelen mentioned this pull request Sep 17, 2024
Closed
Manangka approved these changes Sep 17, 2024
View reviewed changes
Comment thread imod/mf6/wel.py Outdated

sonarqubecloud Bot commented Sep 17, 2024

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

JoerivanEngelen merged commit fe1c630 into imod5_converter_feature_branch Sep 17, 2024
JoerivanEngelen deleted the issue_#1209_bypass_ValueError_well_assign branch September 17, 2024 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Manangka Manangka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option to bypass ValueError for removed wells during well assigning in to_mf6_pkg

2 participants

Back | FazBrowse Home | New Git URL