FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(chat): restore conversation-scoped ask from conversation view and sidebar by dembrane-sam-bot · Pull Request #1057 · Dembrane/echo · GitHub

Repository navigation

feat(chat): restore conversation-scoped ask from conversation view and sidebar - #1057

Closed
dembrane-sam-bot wants to merge 1 commit into
mainfrom
sam/fix-conversation-ask-scope
Closed

dembrane-sam-bot wants to merge 1 commit into
mainfrom
sam/fix-conversation-ask-scope

Conversation

dembrane-sam-bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Restores pre-selection of the current conversation when opening Ask from the sidebar while viewing a conversation (NavItem forwards state.selectedConversationIds).
  • Adds a direct Ask button in the conversation detail header (ProjectConversationRoute), gated for non-observer roles and unlocked conversations.
  • Allows NewChatRoute to read conversationId / conversation_id from URL search params in addition to router state.

Fixes ECHO-975

Context

Reported by Pauline in #gen-engineering: clicking Ask from within a conversation previously pre-selected that conversation as the scope, but this was lost when sidebar navigation was decoupled from conversation context and there was no direct action inside the conversation view.

Confidence

High. The pre-selection and focus chip logic in NewChatRoute is already fully implemented; this wires the missing entry points.

linear Bot commented Sep 10, 2026

Copy link
Copy Markdown

ECHO-975

spashii closed this Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL