fix(audio): handle uppercase extensions in split_audio_chunk and mime lookup - #1092
Closed
dembrane-sam-bot wants to merge 2 commits into
Closed
dembrane-sam-bot wants to merge 2 commits into
dembrane-sam-bot wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… lookup Replace chunk_file_format string replacement with os.path.splitext when constructing the converted output audio path. When audio files are uploaded with uppercase extensions (e.g. Windows 8.3 alias IN685F~1.M4A), case-sensitive .replace() left the extension unchanged, causing convert_and_save_to_s3 to raise a format mismatch ValueError. Also normalize mime type lookup via get_file_format_from_file_path. Closes: ECHO-987
dembrane-sam-bot
enabled auto-merge
September 23, 2026 12:14
Copy link
Copy Markdown
Sorry, something went wrong.
auto-merge was automatically disabled
October 10, 2026 09:18
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes in the system
Hotfix Candidate Note
This change touches only audio_utils.py and applies cleanly to v2.4.2 (the current production tag) without merge conflicts.
Closes: ECHO-987
Confidence
High. The reproduction was isolated to split_audio_chunk doing a case-sensitive .replace() on normalized format strings against raw S3 paths. Unit tests cover case variations and path preservation.