| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thank you for the contribution and for tracing the inconsistent test classification through extraction and MCP filtering. This is now triaged as a high-priority parsing-quality bug for 0.9.1-rc. Our community PR queue is currently quite full, so it may take a little time before we can complete the review and, if approved, merge it. We are doing our best to support community contributions and will return with code-grounded feedback as capacity opens. |
Sorry, something went wrong.
|
A quick note so this does not sit here looking like your problem: your red CI is not caused by your change. The failure is FAIL: invalid Windows PATH smoke seam fell back to the live registry — a main-side smoke seam issue, fixed on main by #1346 after your run. Your diff is not implicated. One thing worth knowing, because it will save you a wasted click: "Re-run failed jobs" will not clear it. A re-run re-tests the same recorded merge commit and fails identically. Only a fresh push refreshes the merge ref — so a rebase on current main and a push is what picks up the fix. Apologies for the delay. We are working through a large review backlog oldest-first; the queue is real rather than a judgement on this PR. |
Sorry, something went wrong.
…ilter Function/Method nodes only got is_test=true via a Rust #[test] attribute check; the per-file test-file flag (cbm_is_test_file) was set on the Module node but never propagated to the definitions inside it, so e.g. a C function in tests/helpers/fixtures.c stayed is_test=false — invisible to store.c's is_test!=1 filters — even though trace_path's own independent path check already treated the file as a test. Propagate is_test_file into extract_func_def and push_method_def, and teach cbm_is_test_file the same tests/ (and test/, spec/, __tests__/) directory convention cbm_is_test_path already uses, so a non-test_-named file anywhere under tests/ is caught too. Separately, trace_call_path's own include_tests filter (mcp.c is_test_file) matched a nested ".../tests/..." path but not a project-root-relative one, so tests/repro/foo.c leaked into results with the default include_tests=false; add the missing tests/ (and test/, spec/, __tests__/) prefix check. Closes DeusData#1294. Signed-off-by: Yyunozor <yyunozor@icloud.com>
|
Merged (33a3f03) — thank you! Mirroring cbm_is_test_path instead of inventing a new convention, and shipping both positive and negative reproduce-first tests, made this a textbook review. The 4-way is-test-path duplication you flagged is a real follow-up; noted. Heads-up in the notes: graphs reindexed on the next release will intentionally reclassify defs under tests/ as tests. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Closes #1294.
Summary
Verification
Known limitations