fix(daemon): add native FreeBSD process-image identity and /home log-path alias - #1467
Conversation
Sorry, something went wrong.
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Sorry, something went wrong.
private_log_directory_path_copy shared the /home root-owned alias
between __APPLE__ and __FreeBSD__. macOS never needed /home resolved
in this security-sensitive step; split the alias list so Darwin keeps
{/tmp, /var} and only FreeBSD gains /home -> /usr/home.
Signed-off-by: Pedro Ramos <131530838+pr9000@users.noreply.github.com>
Extends runtime_process_image_reference_* (self/peer process image acquisition and comparison) to FreeBSD, previously guarded only for _WIN32/__APPLE__/__linux__. Uses sysctl(KERN_PROC_PATHNAME) to resolve a process's executable path without depending on procfs. Renames runtime_linux_stat_same_image to runtime_posix_stat_same_image now that the same comparison logic serves Linux, macOS, and FreeBSD. Signed-off-by: Pedro Ramos <131530838+pr9000@users.noreply.github.com>
Signed-off-by: Pedro Ramos <131530838+pr9000@users.noreply.github.com>
|
Thank you for splitting the FreeBSD process-identity and log-path work into a focused change. Because this extends platform support and touches process identity and path handling, I have routed it to 0.11.0-rc for a careful correctness and security-aware review. The community queue is currently full, so detailed feedback may take a little time. |
Sorry, something went wrong.
|
Merged — thank you, and thank you for the discipline: splitting this out of #1138 exactly as asked, using the native KERN_PROC_PATHNAME sysctl with the O_NOFOLLOW/fstat double-check rather than a procfs shortcut, and scoping the /home→/usr/home alias strictly to FreeBSD. With the CLI self-path half already in (305b89b), FreeBSD support is now coherent end-to-end. Honest-limits note we'll carry in the docs: there is no FreeBSD CI leg, so this path is community-verified — regressions reports welcome. |
Sorry, something went wrong.
|
Quick note on the FreeBSD CI leg you mentioned: #1422 is already open and green (32/32 checks), just waiting in the queue. Once that lands, the 'community-verified' caveat can drop from the docs. |
Sorry, something went wrong.
What does this PR do?
Adds native FreeBSD support to the daemon's process-image identity logic in src/daemon/runtime.c and scopes a security-sensitive /home log-path alias to FreeBSD only in src/daemon/ipc.c.
runtime_process_image_reference_acquire/_matches_process were guarded only for _WIN32/__APPLE__/__linux__, with FreeBSD falling through to a stub that always returned false. This broke the daemon's build-fingerprint capture and made install refuse to proceed on FreeBSD ("active CBM sessions and operations could not be stopped safely"). Adds a sysctl(CTL_KERN, KERN_PROC, KERN_PROC_PATHNAME, pid)-based FreeBSD branch, mirroring the existing macOS/Linux pattern, and renames runtime_linux_stat_same_image to runtime_posix_stat_same_image now that the comparison logic serves all three platforms.
private_log_directory_path_copy previously shared the /home root-owned alias between __APPLE__ and __FreeBSD__. macOS never needed /home resolved in this security-sensitive step; the alias list is now split so Darwin keeps {/tmp, /var} and only FreeBSD gains /home -> /usr/home.
Split out of #1138 per review feedback — this covers the daemon-side platform port; CLI self-path resolution and the activation_transaction.c guard fix are in separate PRs.
Checklist
unsigned commits (DCO, see CONTRIBUTING.md)