FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Limit how many local backups are kept by GabrielDuf · Pull Request #5318 · Devolutions/UniGetUI · GitHub

Limit how many local backups are kept - #5318

Merged
Gabriel Dufresne (GabrielDuf) merged 3 commits into
mainfrom
feature/5279-local-backup-retention-limit
Aug 24, 2026
Merged

Limit how many local backups are kept#5318
Gabriel Dufresne (GabrielDuf) merged 3 commits into
mainfrom
feature/5279-local-backup-retention-limit

Conversation

Copy link
Copy Markdown
Contributor

This pull request introduces a comprehensive backup retention feature for local backups, allowing users to limit the number of backup files kept and to manage backup file naming and retention more flexibly. The changes affect both the backend logic and the user interface, and include robust tests to ensure correct behavior.

Backup retention and file management enhancements:

  • Added new settings and UI controls to allow users to specify the maximum number of local backups to retain, with options for predefined limits or a custom value. The oldest backups are deleted when the limit is exceeded.
  • Updated backup file naming logic to support timestamped files and to only apply retention logic when separate files per backup (timestamping) is enabled.
  • Added new settings keys (MaxLocalBackupCount, MaxLocalBackupCountCustom) and their resolution in the settings engine.

User interface improvements:

  • Updated the backup settings page to include new controls for backup retention, including a combobox for selecting retention limits and a textbox for custom values, with dynamic enablement and layout.
  • Improved the search index for settings to include new backup retention options and updated the description of timestamped backups.

Testing and reliability:

  • Added a comprehensive test suite (LocalBackupManagerTests.cs) to verify backup retention logic, file naming, settings integration, and edge cases such as unrelated files and non-Gregorian calendars.

These changes provide users with greater control over backup file management, improve clarity in the UI, and ensure robust, predictable behavior for backup retention.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Adds configurable retention for timestamped local backups across backup creation, IPC, settings UI, localization, and tests.

Changes:

  • Centralizes backup naming, directory resolution, and retention.
  • Adds retention settings and UI controls.
  • Adds IPC fields and retention tests.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/UniGetUI.Interface.IpcApi/IpcBackupApi.cs Exposes and applies retention through IPC.
src/UniGetUI.Core.Tools/LocalBackupManager.cs Implements naming and retention logic.
src/UniGetUI.Core.Tools.Tests/LocalBackupManagerTests.cs Tests retention and timestamp handling.
src/UniGetUI.Core.Settings/SettingsEngine_Names.cs Defines retention settings keys.
src/UniGetUI.Avalonia/Views/Pages/SettingsPages/Backup.axaml.cs Manages retention control layout.
src/UniGetUI.Avalonia/Views/Pages/SettingsPages/Backup.axaml Adds retention controls.
src/UniGetUI.Avalonia/ViewModels/Pages/SettingsPages/BackupViewModel.cs Connects settings and backup logic.
src/UniGetUI.Avalonia/Infrastructure/SettingsSearchIndex.cs Indexes new settings.
src/Languages/lang_en.json Adds English localization keys.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Gabriel Dufresne (GabrielDuf) merged commit b822852 into main Aug 24, 2026
6 checks passed
Gabriel Dufresne (GabrielDuf) deleted the feature/5279-local-backup-retention-limit branch August 24, 2026 15:34
Gabriel Dufresne (GabrielDuf) linked an issue Aug 24, 2026 that may be closed by this pull request
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Local Backups History Limit

3 participants


Back | FazBrowse Home | New Git URL