ZlibStream: Only verify Adler32 checksum if all data was read - #243
Open
qmfrederik wants to merge 1 commit into
Open
ZlibStream: Only verify Adler32 checksum if all data was read#243qmfrederik wants to merge 1 commit into
qmfrederik wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
It's a bit shady to do checksum validation in a .Dispose method and to throw from there, since .Dispose should never throw. @LordMike what do you think? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .Dispose method in ZlibStream will attempt to verify the Adler32 checksum at the end of the stream.
The check will fail if not all decompressed data was read, since not all data was checksummed and the checksum will not match.
This PR updates the .Dispose logic a bit to only validate the checksum when we're sure all decompressed data has been read.