update with DSv0.1 improvements - #150
Merged
ErinWeisbart merged 1 commit intoMay 18, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bethac07
reviewed
May 18, 2023
Comment thread
config.py
| SQS_QUEUE_NAME = APP_NAME + 'Queue' | ||
| SQS_MESSAGE_VISIBILITY = 1*60 # Timeout (secs) for messages in flight (average time to be processed) | ||
| SQS_DEAD_LETTER_QUEUE = 'arn:aws:sqs:some-region:111111100000:DeadMessages' | ||
| SQS_DEAD_LETTER_QUEUE = 'user_DeadMessages' |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
It's possible I missed it, but can you check if the corresponding run.py code to handle this change was added? I didn't see it.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
already in run.py line 22, from #142
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.