Move away from Cloud9 and change the instruction for Chromebook - #1847
Merged
das-g merged 7 commits intoSep 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
in order to make it work with GitHub Codespace. It also doesn't break anything for local environment.
Copy link
Copy Markdown
Contributor
Author
|
Hey @das-g , do you have some suggestions for the PR? Should I add something else? |
Sorry, something went wrong.
das-g
requested changes
Sep 27, 2024
Comment thread
en/chromebook_setup/README.md
Comment thread
en/chromebook_setup/images/create-new-repo.png
Comment thread
en/chromebook_setup/instructions.md
Outdated
Comment thread
en/chromebook_setup/instructions.md
Outdated
Comment thread
en/chromebook_setup/instructions.md
Outdated
Comment thread
en/chromebook_setup/instructions.md
Outdated
Comment thread
en/chromebook_setup/instructions.md
Outdated
Comment thread
en/chromebook_setup/instructions.md
Outdated
Comment thread
en/chromebook_setup/instructions.md
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Hey @das-g , Thank you very much for the comments! I'll answer to them one by one and then I'll send the updated PR. |
Sorry, something went wrong.
- Reverted the note for Chromebook setup. - Renamed all screenshots and text regarding the first repository creation to "my-first-repo". - Updated the "Deploy" chapter with more screenshots. - Fixed the "Create GitHub account" instructions for Chromebook setup. - Used a numbered list for Chromebook instructions. - Corrected indentation in the Chromebook markdown.
added the separate section "First Git commands".
das-g
approved these changes
Sep 29, 2024
das-g
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great work! Thank you very much!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue: #1081
Changes in this pull request: