Use Ubuntu 24.04 for rename from util-linux - #1856
Conversation
Sorry, something went wrong.
On Ubuntu the file /usr/bin/rename is managed through alternatives because there are multiple implementations. It appears that awalsh128/cache-apt-pkgs-action doesn't update alternatives when a package is cached which means /usr/bin/rename isn't present. The latest image will change to 24.04 on between December and January but on 24.04 there is rename.ul from util-linux which also provides the rename. That avoids the need to rely on awalsh128/cache-apt-pkgs-action for it and the alternatives interaction.
Can we make the stuff that runs for PRs (currently defined in .github/workflows/test.yml) more similar to that that would run on master (currently defined in .github/workflows/deploy.yml)? IMO the only difference should be that PRs must not deploy to the production location. That way, the checks for PRs would test almost everything of the productive CI/CD (e.g. also the renaming). |
Sorry, something went wrong.
das-g
left a comment
There was a problem hiding this comment.
Seems reasonable.
Sorry, something went wrong.
Though for now / for this change here: As the continuous build is currently broken anyway, we could just merge this and see if it gets better. I can't imagine it to have any disastrous consequences: Either it makes it work, or it keeps the build failing similarly to now. 🤷 Thus: Feel free to merge. |
Sorry, something went wrong.
#1835 was the start for that, but I rarely have the time to work on Django things. That one was mostly done during a DjangoGirls workshop where the students didn't need a lot of guidance. |
Sorry, something went wrong.
|
This is really weird: https://github.com/DjangoGirls/tutorial/actions/runs/11917391625/job/33212329587 failed on
But then later versions did deploy correctly. Almost like it was always using the old workflow file. Perhaps that is why the original change only started to break after the first run? This is not how I thought GHA was supposed to work. |
Sorry, something went wrong.
I'm unsure why this broke. I also looked at https://honkit.netlify.app/ebook which mentions you can publish an ebook with a specific name, but figured this was the shortest path. It's untested now.
Right after submitting this I had a theory why it broke. On the first run it passed, but after that it started to fail. The first run it couldn't have cached the package with awalsh128/cache-apt-pkgs-action while it has on the later runs.
/usr/bin/rename is provided via alternatives:
I suspect awalsh128/cache-apt-pkgs-action ignores alternatives so /usr/bin/rename isn't present when a cache is used.
This updates to Ubuntu 24.04 and relies on rename from util-linux which bypasses the need to cache it altogether.
I can't think of an easy way to test this.
Fixes #1855