fix #1147 (search environments.txt file for conda environments) by DonJayamanne · Pull Request #1240 · DonJayamanne/pythonVSCode · GitHub

environments.txt file returns conda environments not returned by the command conda info --envs

Missing a newline.

fixed.

Is not ending comments in a period a thing in the TypeScript world? (Serious question because it's definitely a thing to always use a period in Python.) Otherwise I would definitely use an exclamation point here. 😄 (And if you don't have a preference then I vote for putting in periods to know that a comment definitely is finished and not accidentally incomplete.)

Is not ending comments in a period a thing in the TypeScript world

Never heard of this.

Now i have

No async/await yet in the version of TypeScript that VS Code uses?

Old habbits die hard, async await is available and used.
I'm using promises as well, in most of these places as we I to maximize parallelism... (i.e. return promises) and await on ALL where possible

Missing a newline.

The name prev is misleading since it's a collection and not a single item like current. Maybe rename it accum or accumulator (typical name from functional programming)?

agreed

What are these comments for? They seem to (be trying to) mirror what the code already says so I'm wondering what the benefit is.

I thought it would be best to write the comments out. Else one might ask whey use environments.txt as well as conda info --env. This makes it obvious that environments.txt can contain additional items. Comment removed.

Sorry for the ambiguity of that comment, I meant the @export comments and such more than the block comments. (I totally support block comments 😄 )

This doesn't match the CondaEnvFileService name below.

Is it worth keeping the paths trimmed instead of tossing the trimmed result? I.e.

interpreterPaths.map(String.prototype.trim).filter(item => item.length > 0);

Agreed

Any reason not to keep the trimmed version?

This is going to be tricky once Anaconda Co starts to use that name instead of Continuum Analytics.

Will add both company names. I'm not too concerned even if it doesn't work as its merely a formatting issue.

DonJayamanne and others added 7 commits September 26, 2017 09:35

check envfile for conda environments

171be3c

add support for linux

ee76e9b

fixed tests

37f6332

fixed typo

fd26b23

fix test on linux

d5298ba

renamed provider to service

bdb0071

oopsy

690aaa9

DonJayamanne added the enhancement label Sep 26, 2017

DonJayamanne added this to the October 2017 milestone Sep 26, 2017

DonJayamanne requested a review from brettcannon September 26, 2017 17:29

brettcannon reviewed Sep 26, 2017

View reviewed changes

DonJayamanne added 2 commits September 26, 2017 13:45

code review fixes

2fa2475

force a new line

070637f

DonJayamanne merged commit b46ae28 into master Sep 26, 2017

DonJayamanne deleted the 1147envfile branch October 11, 2017 18:02

+                  private locators: IInterpreterLocatorService[] = [];
+                  constructor(private virtualEnvMgr: VirtualEnvironmentManager) {
+                      const versionService = new InterpreterVersionService();
+                      // The order of the services is important

+                          .then(interpreters => _.flatten(interpreters))
+                          .then(items => items.map(fixInterpreterDisplayName))
+                          .then(items => items.map(fixInterpreterPath))
+                          .then(items => items.reduce<PythonInterpreter[]>((prev, current) => {

+               * However all these environments seem to be listed in the environments.txt file (confirmed on windows and linux)
+               * @export
+               * @class CondaEnvFileProvider
+               * @implements {IInterpreterLocatorService}

+               * Environments created using the command 'conda create --p python=x.x' are not returned by the above command
+               * However all these environments seem to be listed in the environments.txt file (confirmed on windows and linux)
+               * @export
+               * @class CondaEnvFileProvider

+                          })
+                          .then(promises => Promise.all(promises))
+                          .then(interpreterPaths => {
+                              return interpreterPaths.filter(item => item.trim().length > 0);

+                      return getInterpreterDisplayName(pythonPath)
+                          .catch(() => defaultValue);
+                  }
+              }

                
                    No newline at end of file

+                  }
+                  public getInterpreters() {
+                      if (this.interpreters.length > 0) {
+                          return Promise.resolve(this.interpreters);

+                  if (stdout.length === 0) {
+                      return '';
+                  }
+                  const lines = stdout.split(/\r?\n/g).filter(line => line.trim().length > 0);

+                      return this.versionService.getVersion(interpreter, path.basename(interpreter))
+                          .then(version => {
+                              // Strip company name from version
+                              const startOfCompanyName = version.indexOf(`:: ${AnacondaCompanyName}`);

fix #1147 (search environments.txt file for conda environments) by DonJayamanne · Pull Request #1240 · DonJayamanne/pythonVSCode · GitHub

fix #1147 (search environments.txt file for conda environments) - #1240

fix #1147 (search environments.txt file for conda environments)#1240DonJayamanne merged 9 commits intomasterDonJayamanne/pythonVSCode:masterfrom 1147envfileDonJayamanne/pythonVSCode:1147envfileCopy head branch name to clipboard

Conversation

DonJayamanne commented Sep 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix #1147 (search environments.txt file for conda environments)#1240
DonJayamanne merged 9 commits into
masterfrom
1147envfile