feat(app): reach Archived and Trash from the home navigation (TKT-380) - #63
Open
sepo-eng wants to merge 1 commit into
Open
feat(app): reach Archived and Trash from the home navigation (TKT-380)#63sepo-eng wants to merge 1 commit into
sepo-eng wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Both views existed and neither had a way in: /archived and /trash were reachable only by typing the URL (feedback 173, noted twice in runbooks). They join the home utility nav beside Settings and Help, using the archive and trash icons already in the V2 set. Labels reuse the views' own title keys, which all 65 locales already carry, rather than adding nav-specific keys that would need 65 translations to say the same two words. The regression test clicks the links rather than asserting they exist -- an element that renders but cannot be clicked would satisfy the weaker check and still leave the views unreachable, which is the actual complaint. Confirmed the test fails without the change: it is coverage, not decoration. HomeUtilityNav renders twice, once for wide viewports and once for narrow, so the locators resolve the visible instance and cannot pass against the hidden one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KbNYZHcnxRCknFmhhPHe7L
Copy link
Copy Markdown
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback 173: /archived and /trash were reachable only by typing the URL — no navigation affordance. Noted twice in runbooks.
The change
Both views join the home utility nav beside Settings and Help, using the archive and trash icons already present in the V2 icon set.
No new translation keys. The labels reuse the views' own archived.title / trash.title, which all 65 locale files already carry. Adding nav-specific keys would have meant 65 translations to say the same two words, and would have put this on the wrong side of TKT-373's i18n backlog.
The nav lives under the new layout only, which is where these routes are registered (settings.general.newLayoutDesigns()).
Verification
A regression spec that clicks the links, rather than asserting they are present:
Typecheck clean. oxlint: 1 warning, pre-existing on this file.
A note on the diff
home-projects-view.tsx is prettier-dirty on dev — running prettier --write over it reformats a ~60-line block nobody in this change touched. That reformatting is deliberately not included; the diff is +23 lines, all of them this feature. My own lines were checked against prettier separately and need no changes.
(I nearly recorded the opposite: an earlier check copied the file to a temp directory, where the repo's prettier config does not apply, and reported it clean. The check inside the repo is the one that counts.)
🤖 Generated with Claude Code
https://claude.ai/code/session_01KbNYZHcnxRCknFmhhPHe7L