FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make some methods in Dirty module public by andrykonchin · Pull Request #627 · Dynamoid/dynamoid · GitHub

Make some methods in Dirty module public - #627

Merged
andrykonchin merged 3 commits into
masterfrom
make-some-methods-in-dirty-module-public
Jan 14, 2023
Merged

Make some methods in Dirty module public#627
andrykonchin merged 3 commits into
masterfrom
make-some-methods-in-dirty-module-public

Conversation

Copy link
Copy Markdown
Member

Make the following existing Dirty methods public:

  • clear_changes_information
  • changes_applied
  • clear_attribute_changes

These methods are public in Rails' ActiveModel - https://api.rubyonrails.org/classes/ActiveModel/Dirty.html

andrykonchin force-pushed the make-some-methods-in-dirty-module-public branch from 7e8b57b to 5257766 Compare January 13, 2023 11:10

codecov Bot commented Jan 13, 2023
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #627 (a5705a1) into master (13ee680) will decrease coverage by 0.00%.
The diff coverage is 97.50%.

❗ Current head a5705a1 differs from pull request most recent head 3ab00ba. Consider uploading reports for the commit 3ab00ba to get more accurate results

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   90.17%   90.17%   -0.01%     
==========================================
  Files          60       60              
  Lines        3054     3053       -1     
==========================================
- Hits         2754     2753       -1     
  Misses        300      300              
Impacted Files Coverage Δ
lib/dynamoid/dirty.rb 96.38% <97.50%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

andrykonchin requested a review from pboling January 13, 2023 11:20
andrykonchin force-pushed the make-some-methods-in-dirty-module-public branch from 5257766 to da97dac Compare January 13, 2023 11:20
andrykonchin force-pushed the make-some-methods-in-dirty-module-public branch from da97dac to 3ab00ba Compare January 13, 2023 11:25

Copy link
Copy Markdown

Package Line Rate Health
dynamoid 90%
Summary 90% (2753 / 3053)

Minimum allowed line rate is 90%

andrykonchin merged commit 77f956b into master Jan 14, 2023
andrykonchin deleted the make-some-methods-in-dirty-module-public branch January 14, 2023 09:53
andrykonchin added this to the v3.9.0 milestone Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL