FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix `unless_exists` example in README.md by andrykonchin · Pull Request #660 · Dynamoid/dynamoid · GitHub

Fix unless_exists example in README.md - #660

Merged
andrykonchin merged 4 commits into
masterfrom
fix-unless-exists-example-in-readme
May 27, 2023
Merged

Fix unless_exists example in README.md#660
andrykonchin merged 4 commits into
masterfrom
fix-unless-exists-example-in-readme

Conversation

andrykonchin commented May 27, 2023
edited
Loading

Copy link
Copy Markdown
Member

Close #657

Changes:

  • fixed example in the README file
  • documented unless_exists option of persisting methods
  • refactored and removed if_exists option, that was available but is an implementation detail and isn't documented

codecov Bot commented May 27, 2023
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #660 (8ca0e64) into master (c9574f4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 8ca0e64 differs from pull request most recent head 464f115. Consider uploading reports for the commit 464f115 to get more accurate results

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   90.34%   90.33%   -0.02%     
==========================================
  Files          62       62              
  Lines        3160     3156       -4     
==========================================
- Hits         2855     2851       -4     
  Misses        305      305              
Impacted Files Coverage Δ
lib/dynamoid/adapter_plugin/aws_sdk_v3.rb 94.21% <ø> (-0.09%) ⬇️
lib/dynamoid/config.rb 90.32% <100.00%> (ø)
lib/dynamoid/persistence.rb 98.17% <100.00%> (-0.02%) ⬇️
lib/dynamoid/persistence/save.rb 96.36% <100.00%> (ø)
lib/dynamoid/persistence/update_fields.rb 100.00% <100.00%> (ø)

andrykonchin force-pushed the fix-unless-exists-example-in-readme branch from 30a8a2c to 464f115 Compare May 27, 2023 19:31

Copy link
Copy Markdown

Package Line Rate Health
dynamoid 90%
Summary 90% (2851 / 3156)

Minimum allowed line rate is 90%

andrykonchin merged commit 7896f96 into master May 27, 2023
andrykonchin deleted the fix-unless-exists-example-in-readme branch May 27, 2023 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conditional updates are incorrect in README

1 participant


Back | FazBrowse Home | New Git URL