Fix saving persisted model and delete item attributes with nil values - #681
Merged
andrykonchin merged 1 commit intoAug 20, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… if config.store_attribute_with_nil_value = false
Copy link
Copy Markdown
Minimum allowed line rate is 90% |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 90.33% 90.35% +0.01%
==========================================
Files 62 62
Lines 3156 3162 +6
==========================================
+ Hits 2851 2857 +6
Misses 305 305
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix saving persisted model and delete item attributes with nil values if config.store_attribute_with_nil_value = false.
The issue was introduced in #623 by switching from PutItem to UpdateItem for persisted models.
Closes #679