Allow ActiveSupport::HashWithIndifferentAccess of yaml parse - #757
Open
llpereiras wants to merge 1 commit into
Open
Allow ActiveSupport::HashWithIndifferentAccess of yaml parse#757llpereiras wants to merge 1 commit into
llpereiras wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
lmpereirayouse
approved these changes
Jun 7, 2024
Copy link
Copy Markdown
Member
|
I agree that it would be convenient to allow serialising such classes like HashWithIndifferentAccess. So the only missing thing in the PR is specs for the new feature. Could you please add them? But TBH I like mentioned above config option yaml_column_permitted_classes. And use_yaml_unsafe_load could also be useful or at least convenient for developers that are familiar with ActiveRecord. So I am open to adding them. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialized field are stored with ActiveSupport
In my model, I added this:
when I read the record, I received this error:
I think, the most of the apps use rails and ActiveSupport, so I think should be a good addiction to add the support of ActiveSupport
For the extra informattion, I doesn't use active record gem.
Because of that, the configuration of active_record like this
config.active_record.use_yaml_unsafe_load
OR
config.active_record.yaml_column_permitted_classes = [ActiveSupport::HashWithIndifferentAccess]
doesn't work for me.