Fix primary key validation in transactional methods - #987
Merged
andrykonchin merged 3 commits intoMar 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
andrykonchin
force-pushed
the
ak/fix-primary-key-validation-in-transactional-methods
branch
from
a226f14 to
d97772f
Compare
March 5, 2026 17:50
Copy link
Copy Markdown
Minimum allowed line rate is 90% |
Sorry, something went wrong.
andrykonchin
deleted the
ak/fix-primary-key-validation-in-transactional-methods
branch
March 5, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix transactional #save and #destroy to validate primary key (and raise MissingHashKey, MissingRangeKey if keys are blank) after running before/around callbacks.
Close #986