FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add pre-configure hook for Visit to deal with filtered zlib dependency by pavelToman · Pull Request #305 · EESSI/software-layer-scripts · GitHub

/ software-layer-scripts Public

add pre-configure hook for Visit to deal with filtered zlib dependency - #305

Merged
boegel merged 3 commits into
EESSI:mainfrom
pavelToman:patch-1
Sep 20, 2026
ConversationCommits (3)ChecksFiles changed
Merged

add pre-configure hook for Visit to deal with filtered zlib dependency#305
boegel merged 3 commits into
EESSI:mainfrom
pavelToman:patch-1

Conversation

pavelToman commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

VisIt explicitly configures zlib through -DVISIT_ZLIB_DIR.

In EESSI, zlib is filtered as an EasyBuild dependency because it is provided by the compatibility layer. As a result, the VisIt configure step can fail to locate zlib:

VISIT_ZLIB_DIR not set.
VisIt requires lib z and it could not be found.

Add a VisIt-specific pre-configure hook that, when zlib is a filtered dependency, ensures -DVISIT_ZLIB_DIR points to ${EESSI_EPREFIX}/usr.

If -DVISIT_ZLIB_DIR is already present in configopts, its value is replaced. If it is not present, the option is added.

Required for EESSI/software-layer#1525

pavelToman mentioned this pull request Sep 16, 2026
Open
boegel requested changes Sep 16, 2026
View reviewed changes
Comment thread eb_hooks.py Outdated
boegel changed the title Add Visit preconfigure hook - fix zlib detection for Visit add pre-configure hook for Visit to deal with filtered zlib dependency Sep 20, 2026
boegel approved these changes Sep 20, 2026
View reviewed changes

boegel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

tested manually, works like a charm, thanks @pavelToman!

boegel commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace
bot: build repo:eessi.io-2026.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace

eessi-bot-jsc Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2023.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_305/15639582

date job status comment
Sep 20 16:10:16 UTC 2026 submitted job id 15639582 awaits release by job manager
Sep 20 16:10:34 UTC 2026 released job awaits launch by Slurm scheduler
Sep 20 16:13:54 UTC 2026 running job 15639582 is running
Sep 20 16:16:10 UTC 2026 finished 😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15639582.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2023.06-software-linux-aarch64-nvidia-grace-17899209010.tar.gzsize: 0 MiB (32379 bytes)
entries: 1
modules under 2023.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2023.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2023.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2023.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 20 16:16:10 UTC 2026 test result 😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15639582.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case

eessi-bot-jsc Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2025.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_305/15639583

date job status comment
Sep 20 16:10:21 UTC 2026 submitted job id 15639583 awaits release by job manager
Sep 20 16:10:30 UTC 2026 released job awaits launch by Slurm scheduler
Sep 20 16:11:46 UTC 2026 running job 15639583 is running
Sep 20 16:13:55 UTC 2026 finished 😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15639583.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2025.06-software-linux-aarch64-nvidia-grace-17899207070.tar.gzsize: 0 MiB (32382 bytes)
entries: 1
modules under 2025.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2025.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2025.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2025.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 20 16:13:55 UTC 2026 test result 😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15639583.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case

eessi-bot-jsc Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2026.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_305/15639584

date job status comment
Sep 20 16:10:27 UTC 2026 submitted job id 15639584 awaits release by job manager
Sep 20 16:11:40 UTC 2026 released job awaits launch by Slurm scheduler
Sep 20 16:16:08 UTC 2026 running job 15639584 is running
Sep 20 16:20:25 UTC 2026 finished 😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15639584.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2026.06-software-linux-aarch64-nvidia-grace-17899210030.tar.gzsize: 0 MiB (32382 bytes)
entries: 1
modules under 2026.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2026.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2026.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2026.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 20 16:20:25 UTC 2026 test result 😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15639584.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case

boegel commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

just want to make sure we don't deploy an outdated copy of our hooks, since I synced with main just before triggering the previous build...

bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace
bot: build repo:eessi.io-2026.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace

eessi-bot-jsc Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2023.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_305/15639597

date job status comment
Sep 20 16:29:27 UTC 2026 submitted job id 15639597 awaits release by job manager
Sep 20 16:29:55 UTC 2026 released job awaits launch by Slurm scheduler
Sep 20 16:33:11 UTC 2026 running job 15639597 is running
Sep 20 16:38:39 UTC 2026 finished 😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15639597.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2023.06-software-linux-aarch64-nvidia-grace-17899222200.tar.gzsize: 0 MiB (32379 bytes)
entries: 1
modules under 2023.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2023.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2023.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2023.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 20 16:38:39 UTC 2026 test result 😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15639597.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Sep 20 16:53:05 UTC 2026 uploaded transfer of eessi-2023.06-software-linux-aarch64-nvidia-grace-17899222200.tar.gz to S3 bucket succeeded

eessi-bot-jsc Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2025.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_305/15639598

date job status comment
Sep 20 16:29:34 UTC 2026 submitted job id 15639598 awaits release by job manager
Sep 20 16:29:51 UTC 2026 released job awaits launch by Slurm scheduler
Sep 20 16:38:37 UTC 2026 running job 15639598 is running
Sep 20 16:44:00 UTC 2026 finished 😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15639598.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2025.06-software-linux-aarch64-nvidia-grace-17899225870.tar.gzsize: 0 MiB (32379 bytes)
entries: 1
modules under 2025.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2025.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2025.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2025.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 20 16:44:00 UTC 2026 test result 😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15639598.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Sep 20 16:53:15 UTC 2026 uploaded transfer of eessi-2025.06-software-linux-aarch64-nvidia-grace-17899225870.tar.gz to S3 bucket succeeded

eessi-bot-jsc Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2026.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_305/15639599

date job status comment
Sep 20 16:29:39 UTC 2026 submitted job id 15639599 awaits release by job manager
Sep 20 16:29:47 UTC 2026 released job awaits launch by Slurm scheduler
Sep 20 16:31:03 UTC 2026 running job 15639599 is running
Sep 20 16:33:12 UTC 2026 finished 😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15639599.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2026.06-software-linux-aarch64-nvidia-grace-17899218450.tar.gzsize: 0 MiB (32382 bytes)
entries: 1
modules under 2026.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2026.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2026.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2026.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 20 16:33:12 UTC 2026 test result 😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15639599.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Sep 20 16:52:56 UTC 2026 uploaded transfer of eessi-2026.06-software-linux-aarch64-nvidia-grace-17899218450.tar.gz to S3 bucket succeeded

boegel commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

staging PR merged

boegel merged commit 7ae3ad5 into EESSI:main Sep 20, 2026
103 of 111 checks passed
bedroge mentioned this pull request Sep 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

boegel boegel approved these changes

Assignees

No one assigned

Labels

bot:deploy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL