FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improved documentation by DebajitKumarPhukan · Pull Request #853 · ESAPI/esapi-java-legacy · GitHub

  1. ESAPI
  2. esapi-java-legacy

Repository navigation

Improved documentation - #853

Merged
kwwall merged 7 commits into
ESAPI:developfrom
DebajitKumarPhukan:develop
Sep 14, 2024
ConversationCommits (7)ChecksFiles changed
Merged

Improved documentation#853
kwwall merged 7 commits into
ESAPI:developfrom
DebajitKumarPhukan:develop

Conversation

DebajitKumarPhukan commented Aug 31, 2024

Copy link
Copy Markdown
Contributor
  1. Updated version to latest available.
  2. Added a quickstart maven example section.

kwwall requested changes Aug 31, 2024
View reviewed changes

kwwall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See my other comments for the changes requested. IMO, our README is already too long.

Comment thread README.md
Comment thread README.md
Comment thread README.md
Comment thread README.md

kwwall commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

@DebajitKumarPhukan - I'd like to do a release soon (no later than 9/22). Do you think you can make the requested changes by then? If not, these changes will have to wait until the end of November.

DebajitKumarPhukan commented Sep 14, 2024
View reviewed changes

DebajitKumarPhukan left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

New updates as per suggestions.

DebajitKumarPhukan commented Sep 14, 2024

Copy link
Copy Markdown
Contributor Author

@kwwall Thank you so much the gentle reminder. I got occupied (and lost a bit) in my day to day work. I have made the necessary changes as requested and also shared some reasons on "why".

kwwall approved these changes Sep 14, 2024
View reviewed changes

kwwall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine with the changes, as-is, although I likely will move some of this to our wiki page. These additions are easily going to push our README.md to 9 pages.

kwwall commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

Since this is only documentation changes, I am going to merge PR this without the approval of @xeno6696 or @jeremiahjstacey.

kwwall merged commit 57c12af into ESAPI:develop Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kwwall kwwall approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL