Repository navigation
Clean up obsolete ESAPI 1.4 comments in config files #474 - #918
Open
AzazelSensei wants to merge 1 commit into
Open
AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ESAPI 1.4 is past EOL and the old encrypt(String)/decrypt(String) compatibility APIs are gone. Drop the leftover 1.4 migration notes from ESAPI.properties copies and the matching javadoc. Fixes ESAPI#474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dropped the leftover ESAPI 1.4 comments from the ESAPI.properties copies used in tests. Those notes still described decrypting with 1.4 and the old encrypt(String)/decrypt(String) methods, which are gone. The production configuration file was already clean.
Also updated the matching javadoc on SecurityConfiguration.
Fixes #474